[aseek-devel] Re: Matt's patch

[Matt Sullivan]

On Thu, 20 Sep 2001, Kir Kolyshkin wrote:

> Matt, I have almost integrated your patch with my minor changes, so you should
> not redone it against the latest CVS. Only one piece of code is still unclear to me.
> Can you comment on this?
> 
>       if(!STRNCMP(str, "ftp://";) && (strstr(str,";type=")))
>               *(strstr(str, ";type"))=0;

It strips off transfer mode setting of ftp URLs (if present). ref. 
http://www.w3.org/Addressing/URL/4_1_FTP.html

I'm not sure why it is there (perhaps it caused issues with ftp proxy server). 
It actually came from further down in parse.cpp in approx. line 1865 of
ParseHtml() (in 1.2.4a unpatched).  In fact the segment of updated code
executed on status HTTP_STATUS_REDIRECT is almost identical now to the code
later on in ParseHtml().

Probably it would be possible now to separate it out into it's own subroutine. 


Matt.