----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3836/#review12865 -----------------------------------------------------------
Ship it! Ship It! - rmudgett On July 22, 2014, 10:14 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3836/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 10:14 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23987 > https://issues.asterisk.org/jira/browse/ASTERISK-23987 > > > Repository: Asterisk > > > Description > ------- > > The BridgeWait application currently creates bridges with the dissolve on > empty flag set. This causes the bridge to be dissolved when the last channel > leaves it. This introduces a race condition where another channel may be > trying to join during this, causing it to fail. Since the lifetime of the > bridge is already associated with the bridge wrapper the bridge does not need > the dissolve on empty flag set. When the last reference goes away the bridge > is destroyed. This ensures that as long as anything has a reference to the > bridge wrapper the bridge is valid and can be joined. > > > Diffs > ----- > > /branches/12/apps/app_bridgewait.c 418809 > > Diff: https://reviewboard.asterisk.org/r/3836/diff/ > > > Testing > ------- > > Ran tests and confirmed no regressions. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
