Hi Chris,
thanks for your analyses and code.
Am 14.04.2017 um 02:18 schrieb Christopher Heckman:
(1) When midi2ly is run, it will print fractions with large numerators
and denominators
…
I have written a patch to fix this.
Could you provide this as a git-formatted patch, please?
(In case of doubt, see
<http://lilypond.org/doc/v2.19/Documentation/contributor/working-with-source-code>)
(2) In line 181 of midi2ly.py, the authors talk about how the 7th of a
minor scale should be raised, but this is not notated. The real issue
is that there are two types of minor scale involved, the harmonic
minor (1 2 b3 4 5 b6 7) and the natural minor (1 2 b3 4 5 b6 b7). The
reason that "C# is not put in the key signature of D minor" is that
the minor scale is the natural minor, not the harmonic minor.
I’d rather say that all these musicotheoretical musings don’t belong
there at all. Instead one could just say:
# induce correct spelling of 7th scale degree in minor keys
(3) At line 677, there's a cryptic comment
# urg, this will barf at meter changes
Is there a brief explanation of the problem available?
Well, apparently this particular code isn’t prepared to deal with meter
changes in the input. What exactly is unclear about that?
Best, Simon
_______________________________________________
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond
