Re: [PATCH parted 3/3] linux: Remove PED_DEVICE_FILE check from _device_set_sector_size

[Hans de Goede]

Hi,

On 01/29/2010 10:31 AM, Jim Meyering wrote:

Hans de Goede wrote:

_device_set_sector_size never get called for devices with a type of
PED_DEVICE_FILE, and having a PED_DEVICE_FILE check inside an ifdef
__390__ block does not make sense.
* libparted/arch/linux.c(_device_set_sector_size): Remove
PED_DEVICE_FILE check.

...

Thanks!
That disjunct is indeed unnecessary.  I added it in

     50b1d2bb1a4e199ca6ecdb73be2d15677600c76d
     dasd: allow the use of a *regular* backing file

thinking that it'd be required when running "make check" on an s390,
since many of those tests use a regular file as backing storage.

However, note that testing for PED_DEVICE_FILE inside s390-specific
code does make sense and is currently required in dasd.c, so I propose
to remove the "and having... does not make sense" part of your log
message:

That is fine by me (removing that part of the log message).

Regards,

Hans


_______________________________________________
bug-parted mailing list
bug-parted@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-parted