cactus-dev  

svn commit: r659474 - in /jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus: internal/client/connector/http/JmsProtocolHandler.java util/JmsConfiguration.java

ptahchiev
Fri, 23 May 2008 01:40:33 -0700

Author: ptahchiev
Date: Fri May 23 01:40:08 2008
New Revision: 659474

URL: http://svn.apache.org/viewvc?rev=659474&view=rev
Log:
Small changes on the JMS components.

Modified:
    
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
    
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java

Modified: 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
URL: 
http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java?rev=659474&r1=659473&r2=659474&view=diff
==============================================================================
--- 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
 (original)
+++ 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/internal/client/connector/http/JmsProtocolHandler.java
 Fri May 23 01:40:08 2008
@@ -1,3 +1,23 @@
+/* 
+ * ========================================================================
+ * 
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * 
+ * ========================================================================
+ */
 package org.apache.cactus.internal.client.connector.http;
 
 import javax.jms.QueueSession;
@@ -15,6 +35,11 @@
 import org.apache.cactus.spi.client.connector.ProtocolState;
 import org.apache.cactus.util.JmsConfiguration;
 
+/**
+ * The JMS protocol handler.
+ * @author ptahchiev
+ *
+ */
 public class JmsProtocolHandler implements ProtocolHandler
 {
     /**
@@ -42,13 +67,19 @@
                return new JmsRequest(session);
        }
 
+    /**
+     * TODO implement this method.
+     */
        public ResponseObjectFactory createResponseObjectFactory(
                        ProtocolState theState) {
-               // TODO Auto-generated method stub
                return null;
        }
 
-       public ProtocolState runTest(Test theDelegatedTest, Test theWrappedTest,
+
+    /**
+     * The overriden runTest method.
+     */
+    public ProtocolState runTest(Test theDelegatedTest, Test theWrappedTest,
                        Request theRequest) throws Throwable 
        {
         // Create the JMS Request object and creates necessary JMS objects
@@ -71,6 +102,7 @@
        
        
     /**
+     * Returns the configuration data.
      * @return configuration data
      */
     private JmsConfiguration getConfiguration()

Modified: 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java
URL: 
http://svn.apache.org/viewvc/jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java?rev=659474&r1=659473&r2=659474&view=diff
==============================================================================
--- 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java
 (original)
+++ 
jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus/util/JmsConfiguration.java
 Fri May 23 01:40:08 2008
@@ -44,8 +44,9 @@
 
         String property =
             System.getProperty("cactus.jndi.initialContextFactory");
-        if (property == null) {
-            new ChainedRuntimeException("Missing Cactus property [" +
+        if (property == null) 
+        {
+            throw new ChainedRuntimeException("Missing Cactus property [" +
                 "cactus.jndi.initialContextFactory" + "]");
         }
         return property;
@@ -61,8 +62,9 @@
 
         String property =
             System.getProperty("cactus.jndi.providerUrl");
-        if (property == null) {
-            new ChainedRuntimeException("Missing Cactus property [" +
+        if (property == null) 
+        {
+            throw new ChainedRuntimeException("Missing Cactus property [" +
                 "cactus.jndi.providerUrl" + "]");
         }
         return property;
@@ -78,8 +80,9 @@
 
         String property =
             System.getProperty("cactus.jndi.securityPrincipal");
-        if (property == null) {
-            new ChainedRuntimeException("Missing Cactus property [" +
+        if (property == null) 
+        {
+            throw new ChainedRuntimeException("Missing Cactus property [" +
                 "cactus.jndi.securityPrincipal" + "]");
         }
         return property;
@@ -95,8 +98,9 @@
 
         String property =
             System.getProperty("cactus.jndi.securityCredentials");
-        if (property == null) {
-            new ChainedRuntimeException("Missing Cactus property [" +
+        if (property == null) 
+        {
+            throw new ChainedRuntimeException("Missing Cactus property [" +
                 "cactus.jndi.securityCredentials" + "]");
         }
         return property;
@@ -112,8 +116,9 @@
 
         String property =
             System.getProperty("cactus.jms.connectionFactoryJndiName");
-        if (property == null) {
-            new ChainedRuntimeException("Missing Cactus property [" +
+        if (property == null) 
+        {
+            throw new ChainedRuntimeException("Missing Cactus property [" +
                 "cactus.jms.connectionFactoryJndiName" + "]");
         }
         return property;



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

  • svn commit: r659474 - in /jakarta/cactus/trunk/framework/framework-12-13-14/src/main/java/org/apache/cactus: internal/client/connector/http/JmsProtocolHandler.java util/JmsConfiguration.java ptahchiev