findbugs findings
Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/0daa8708 Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/0daa8708 Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/0daa8708 Branch: refs/heads/master Commit: 0daa8708dfcc5c0c3803ab2e41542dba134d71d0 Parents: 591b9f9 Author: Stefan Bodewig <bode...@apache.org> Authored: Thu May 11 20:48:49 2017 +0200 Committer: Stefan Bodewig <bode...@apache.org> Committed: Thu May 11 20:48:49 2017 +0200 ---------------------------------------------------------------------- .../apache/commons/compress/archivers/zip/ZipFile.java | 2 +- .../compressors/brotli/BrotliCompressorInputStream.java | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-compress/blob/0daa8708/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java index 486d5e7..4b16b52 100644 --- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java +++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java @@ -1162,7 +1162,7 @@ public class ZipFile implements Closeable { return read; } - void addDummy() { + synchronized void addDummy() { this.addDummy = true; } } http://git-wip-us.apache.org/repos/asf/commons-compress/blob/0daa8708/src/main/java/org/apache/commons/compress/compressors/brotli/BrotliCompressorInputStream.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/compress/compressors/brotli/BrotliCompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/brotli/BrotliCompressorInputStream.java index 91e57ca..6c4bc55 100644 --- a/src/main/java/org/apache/commons/compress/compressors/brotli/BrotliCompressorInputStream.java +++ b/src/main/java/org/apache/commons/compress/compressors/brotli/BrotliCompressorInputStream.java @@ -47,21 +47,11 @@ public class BrotliCompressorInputStream extends CompressorInputStream { } @Override - public int hashCode() { - return decIS.hashCode(); - } - - @Override public int read(final byte[] b) throws IOException { return decIS.read(b); } @Override - public boolean equals(final Object obj) { - return decIS.equals(obj); - } - - @Override public long skip(final long n) throws IOException { return decIS.skip(n); }
