Author: britter
Date: Wed May 17 21:27:03 2017
New Revision: 1795459

URL: http://svn.apache.org/viewvc?rev=1795459&view=rev
Log:
Don't reassign method parameters

Modified:
    
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/Imaging.java

Modified: 
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/Imaging.java
URL: 
http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/Imaging.java?rev=1795459&r1=1795458&r2=1795459&view=diff
==============================================================================
--- 
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/Imaging.java
 (original)
+++ 
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/Imaging.java
 Wed May 17 21:27:03 2017
@@ -162,19 +162,19 @@ public final class Imaging {
      * which may contain an image.
      * @return true if the filename has an image format file extension.
      */
-    public static boolean hasImageFileExtension(String filename) {
+    public static boolean hasImageFileExtension(final String filename) {
         if (filename == null) {
             return false;
         }
-        
-        filename = filename.toLowerCase(Locale.ENGLISH);
+
+        String normalizedFilename = filename.toLowerCase(Locale.ENGLISH);
 
         final ImageParser[] imageParsers = ImageParser.getAllImageParsers();
         for (final ImageParser imageParser : imageParsers) {
             final String[] exts = imageParser.getAcceptedExtensions();
 
             for (final String ext : exts) {
-                if (filename.endsWith(ext.toLowerCase(Locale.ENGLISH))) {
+                if 
(normalizedFilename.endsWith(ext.toLowerCase(Locale.ENGLISH))) {
                     return true;
                 }
             }


Reply via email to