DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32949>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32949

           Summary: FTPClient.setDataTimeout() should contain a default
                    timeout
           Product: Commons
           Version: 1.2 Final
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P4
         Component: Net
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: [EMAIL PROTECTED]


The method FTPClient.setDataTimeout() appears not to have a default value, or 
better said, it appears that the default value is 0, meaning that if a socket 
hangs (which will happen with an ftp connection eventually) you may block 
indefinately waiting on the connection.

If we omit a call to setDataTimeout() it's almost certain that we will face a 
bug in our code later on, and unfortunately it's relatively unlikely that this 
bug will be caught in development. I think it would be far safer to have a 
default timeout value of say, pick a number, maybe 60 seconds? Those that need 
this changes should specically call it to make the change. If you do want it to 
block indefinately (I doubt almost anyone actually wants this) then they should 
explicitly set this to 0, but I think 99.9% of your users will actually want a 
resonable timeout, thus it would be best to set this 'resonable' timeout value 
as the default to safeguard those that miss adding it to their code.

Thanks,
David Parks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to