On Fri, Jun 18, 2010 at 2:26 PM, Sam Spilsbury <[email protected]> wrote:
> On 6/18/10, Jay Catherwood <[email protected]> wrote:
> > (1) The snap to windows checkbox in ccsm has no effect because Snap
> treats
> > any window with struts as an edge, and all windows have struts.
>
> Didn't apply this one. w->struts () should return NULL if there are no
> struts. If all windows have struts then this is a bug in core
>
All right. CompWindow::updateStruts does give all windows struts. I turned
that off and the snapping problem is fixed for me. Patch is attached.
>
> > (2) Windows don't snap to the left edge because it has been erased. The
> > right edge doesn't seem to get erased because it is slightly offscreen,
> so I
> > did the same thing with the left. I don't know if that is exactly the
> right
> > solution, but at least it works.
>
> Applied,
>
It turns out this bug was an artifact of all windows having struts. I think
you can revert this if you apply the patch to updateStruts.
Thanks,
Jay
diff --git a/src/window.cpp b/src/window.cpp
index a5cd40f..b196a6f 100644
--- a/src/window.cpp
+++ b/src/window.cpp
@@ -947,7 +947,7 @@ CompWindow::updateStruts ()
hasOld = false;
}
- hasNew = true;
+ hasNew = false;
newStrut.left.x = 0;
newStrut.left.y = 0;
_______________________________________________
compiz mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/compiz
