Bug#416855: marked as done (FTBFS with GCC 4.3: the meaning of "inline" changed in C99)

[Debian Bug Tracking System]

Your message dated Sun, 20 May 2007 08:47:09 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#416855: fixed in twolame 0.3.10-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---

Package: twolame
Version: 0.3.9-1
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In C99 the meaning of "inline"
changed, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31389
A patch for this problem is below.

> Automatic build of twolame_0.3.9-1 on coconut0 by sbuild/ia64 0.49
...
>  cc -DHAVE_CONFIG_H -I. -I. -I../build -I ../build/ -g -Wall -O2 -std=c99 
> -Wunused -Wall -O3 -c crc.c  -fPIC -DPIC -o .libs/crc.o
> bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but never 
> defined
> bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but never 
> defined
...
> mkdir .libs
> cc -I../build/ -I../libtwolame/ -g -Wall -O2 -std=c99 -Wunused -Wall -O3 -o 
> .libs/twolame frontend.o  /usr/lib/libsndfile.so /usr/lib/libFLAC.so 
> ../libtwolame/.libs/libtwolame.so -lm
> ../libtwolame/.libs/libtwolame.so: undefined reference to `buffer_putbits'
> collect2: ld returned 1 exit status
> make[2]: *** [twolame] Error 1

--- libtwolame/common.h~        2007-03-30 20:07:53.000000000 +0000
+++ libtwolame/common.h 2007-03-30 20:08:10.000000000 +0000
@@ -33,7 +33,7 @@
 #define NO_DLL_INLINE
 #else
 #include "config.h"
-#define NO_DLL_INLINE inline
+#define NO_DLL_INLINE extern inline
 #endif
 
 

-- 
Martin Michlmayr
http://www.cyrius.com/

--- End Message ---

--- Begin Message ---

Source: twolame
Source-Version: 0.3.10-2

We believe that the bug you reported is fixed in the latest version of
twolame, which is due to be installed in the Debian FTP archive:

libtwolame-dev_0.3.10-2_i386.deb
  to pool/main/t/twolame/libtwolame-dev_0.3.10-2_i386.deb
libtwolame0_0.3.10-2_i386.deb
  to pool/main/t/twolame/libtwolame0_0.3.10-2_i386.deb
twolame_0.3.10-2.diff.gz
  to pool/main/t/twolame/twolame_0.3.10-2.diff.gz
twolame_0.3.10-2.dsc
  to pool/main/t/twolame/twolame_0.3.10-2.dsc
twolame_0.3.10-2_i386.deb
  to pool/main/t/twolame/twolame_0.3.10-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mark Purcell <[EMAIL PROTECTED]> (supplier of updated twolame package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 20 May 2007 09:05:10 +0100
Source: twolame
Binary: twolame libtwolame0 libtwolame-dev
Architecture: source i386
Version: 0.3.10-2
Distribution: unstable
Urgency: low
Maintainer: Debian MythTV Team <[EMAIL PROTECTED]>
Changed-By: Mark Purcell <[EMAIL PROTECTED]>
Description: 
 libtwolame-dev - MPEG Audio Layer 2 encoder (development files)
 libtwolame0 - MPEG Audio Layer 2 encoding library
 twolame    - MPEG Audio Layer 2 encoder (command line frontend)
Closes: 416855 419597
Changes: 
 twolame (0.3.10-2) unstable; urgency=low
 .
   * gcc4.3 patch from Martin:
     - FTBFS with GCC 4.3: the meaning of "inline" changed in C99 (Closes:
     #416855)
   * Updated package Description in debian/control:
     - please clarify legal situation in description (Closes: #419597)
Files: 
 07b3c0df6e0cc45f86b972fc38a3f0f2 743 sound optional twolame_0.3.10-2.dsc
 443c0d2fc76d8a2037f725b282c7ff83 6087 sound optional twolame_0.3.10-2.diff.gz
 5551f8b2e2b8716bf71fb1c359351373 112666 libdevel optional 
libtwolame-dev_0.3.10-2_i386.deb
 da61f22e8c09a7e4c8cf0fc1b5e003da 57366 libs optional 
libtwolame0_0.3.10-2_i386.deb
 b5dcbfdb166b73ef903d18ee725186b9 20414 sound optional twolame_0.3.10-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGUAH7oCzanz0IthIRAo6hAJ9S1LAPxoQ78Nuzj5x1YhTSVIWbXACgnWu4
BKdCwrhZ3LCPISRcVxUb2q4=
=UyB7
-----END PGP SIGNATURE-----

--- End Message ---