Hi Joachim,
I am not a Debian Developer or uploader, so I cannot sponsor the upload
myself, but I did a review and local build of 1.2-1 to see if I could help.
What I checked:
- fetched the source with dget from the URL in the RFS
- built it locally with dpkg-buildpackage -us -uc -b on arm64
- checked the resulting package contents, SONAME metadata, and lintian output
I think there is one real packaging issue in the current shared-library
setup:
- the built library file is libpicohttpparser.so.1.2
- the ELF SONAME inside it is libpicohttpparser.so.1
- the -dev package creates libpicohttpparser.so -> libpicohttpparser.so.1
- but the runtime package does not actually ship
libpicohttpparser.so.1 -> libpicohttpparser.so.1.2
So at the moment the unversioned development symlink points to the SONAME
path, but that SONAME path is not present in the runtime package.
This seems to come directly from the current Makefile patch: it builds the
real file as libpicohttpparser.so.${DEB_VERSION_UPSTREAM} and sets the
SONAME to libpicohttpparser.so.1, but does not create the SONAME symlink.
I also noticed a test inconsistency:
- debian/changelog says the tests were changed to test the installed library
with autopkgtest
- but I do not see a debian/tests/ autopkgtest setup in the source package
- and debian/rules currently disables dh_auto_test in normal builds via
DEB_BUILD_OPTIONS filtering for "check", not "nocheck"
So as uploaded, the package builds, but the tests do not appear to run during
normal package builds, and I do not see the promised autopkgtest coverage
either.
For reference, lintian additionally reported:
- libpicohttpparser-dev: extended-description-is-probably-too-short
- libpicohttpparser1: symbols-file-missing-build-depends-package-field
I tried two small prototype fixes for the SONAME issue, both of which built
cleanly locally and produced the expected link layout:
1. Makefile-side fix
- create libpicohttpparser.so.1 -> libpicohttpparser.so.1.2 during build
- patch attached as an example: libpicohttpparser-soname-fix.patch
2. Debian-side packaging fix
- keep the current Makefile patch as-is
- add an override_dh_link rule in debian/rules to create the SONAME link
in the runtime package
- patch attached as an example:
libpicohttpparser-soname-fix-debian-rules.patch
I am not suggesting that either prototype is the only correct fix, only that
both seem to address the missing SONAME symlink cleanly.
The package itself is definitely useful. The security-tracker
embedded-code-copies list currently shows picohttpparser embedded in bind9,
feersum, identity4c, libhttp-parser-xs-perl, and monitoring-plugins, so
getting a good shared library package in would help.
Regards,
James--- a/Makefile
+++ b/Makefile
@@ -32,14 +32,18 @@
LDFLAGS += -shared -Wl,-soname,libpicohttpparser.so.1
TARGET = libpicohttpparser.so.${DEB_VERSION_UPSTREAM}
+SONAME = libpicohttpparser.so.1
SOURCES = picohttpparser.c
HEADERS = picohttpparser.h
OBJECTS = $(SOURCES:.c=.o)
-library: $(TARGET)
+library: $(TARGET) $(SONAME)
$(TARGET): $(OBJECTS)
$(CC) $(FLAGS) $(CFLAGS) $(LDFLAGS) -o $(TARGET) $(OBJECTS)
+
+$(SONAME): $(TARGET)
+ ln -sf $(TARGET) $(SONAME)
test: test-bin
env $(TEST_ENV) $(PROVE) -v ./test-bin
@@ -48,6 +52,6 @@
$(CC) $(CFLAGS) -Wl,--no-as-needed -o $@ -lpicohttpparser $^
clean:
- rm -f test-bin
+ rm -f test-bin $(TARGET) $(SONAME) $(OBJECTS)
.PHONY: test--- a/debian/rules
+++ b/debian/rules
@@ -22,6 +22,10 @@
override_dh_auto_test: ;
endif
+override_dh_link:
+ dh_link -plibpicohttpparser1 usr/lib/$(DEB_HOST_MULTIARCH)/libpicohttpparser.so.$(DEB_VERSION_UPSTREAM) usr/lib/$(DEB_HOST_MULTIARCH)/libpicohttpparser.so.1
+ dh_link
+
%:
dh $@
