Bug#568897: debhelper: DEB_BUILD_OPTIONS=nocheck should prevent override_dh_auto_test rule to be run

[Mike Hommey]

On Tue, Feb 09, 2010 at 02:38:34PM -0500, Joey Hess wrote:
> Mike Hommey wrote:
> > Everything in the subject.
> 
> If I did this, I would need to also make override_dh_strip to be
> skipped when DEB_BUILD_OPTIONS=nostrip.
> 
> One reason to dislike this is it would mean redundant tests in
> dh that'd have to be maintained in parallel with the tests in the
> commands. Especially problimatic if dh sequence addons are used to
> make it call third-party commands that use DEB_BUILD_OPTIONS, since
> dh would not be able to handle them consistently.
> 
> Perhaps a better reason to dislike this is that it violates least
> suprise when rules file refactoring. One can move anything into an
> override target, even if it does not really match the overridden
> debhelper command, and expect it to be run at the appropriate point.
> 
> Here's an example that would cause the package to FTBFS if nocheck
> were tested.
> 
> override_dh_auto_test:
>       # the test suite does not 100% pass at present,
>       # but the output is useful documentation for users
>       (dh_auto_test; echo $?) > test-results
> 
> override_dh_install:
>       dh_install test-results /usr/share/doc/alien/

Agreed. You are free to mark the bug as wontfix or close it, whichever
you feel is more appropriate.

Mike



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org