On 2016-10-10 06:52, Helmut Grohne wrote:
> Source: glibc
> Version: 2.24-3
> Severity: wishlist
> Tags: patch
> User: helm...@debian.org
> Usertags: rebootstrap
> 
> Hi Aurelien,
> 
> Can you add support for the tilegx architecture to glibc? dpkg knows
> about the architecture since 1.18.8 and gcc-6 has some preliminary
> support already. The patch is quite small. Beyond adding it to
> libc6_archs, care needs to be taken to use arch-specific linux headers
> from /usr/include/<triplet>/arch. After applying the patch,
> debian/control must be regeneratd (not included in the patch). Can you
> maintain the diff?
> 
> Helmut

> diff --minimal -Nru glibc-2.24/debian/changelog glibc-2.24/debian/changelog
> --- glibc-2.24/debian/changelog       2016-09-17 20:00:44.000000000 +0200
> +++ glibc-2.24/debian/changelog       2016-10-10 06:36:11.000000000 +0200
> @@ -1,3 +1,10 @@
> +glibc (2.24-3.1) UNRELEASED; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Support tilegx. (Closes: #-1)
> +
> + -- Helmut Grohne <hel...@subdivi.de>  Mon, 10 Oct 2016 06:36:01 +0200
> +
>  glibc (2.24-3) unstable; urgency=medium
>  
>    [ Aurelien Jarno ]
> diff --minimal -Nru glibc-2.24/debian/rules.d/control.mk 
> glibc-2.24/debian/rules.d/control.mk
> --- glibc-2.24/debian/rules.d/control.mk      2016-09-04 01:26:39.000000000 
> +0200
> +++ glibc-2.24/debian/rules.d/control.mk      2016-10-10 06:35:57.000000000 
> +0200
> @@ -1,7 +1,7 @@
>  libc_packages := libc6 libc6.1 libc0.1 libc0.3
>  libc0_1_archs := kfreebsd-amd64 kfreebsd-i386
>  libc0_3_archs := hurd-i386
> -libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
> mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc 
> sparc64 s390x sh4 x32
> +libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
> mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc 
> sparc64 s390x sh4 tilegx x32
>  libc6_1_archs := alpha
>  
>  control_deps := $(wildcard debian/control.in/*) $(addprefix 
> debian/control.in/, $(libc_packages))
> diff --minimal -Nru glibc-2.24/debian/sysdeps/linux.mk 
> glibc-2.24/debian/sysdeps/linux.mk
> --- glibc-2.24/debian/sysdeps/linux.mk        2016-09-04 01:26:39.000000000 
> +0200
> +++ glibc-2.24/debian/sysdeps/linux.mk        2016-10-10 06:35:21.000000000 
> +0200
> @@ -39,6 +39,11 @@
>       else \
>               ln -s $(LINUX_HEADERS)/asm debian/include ; \
>       fi
> +     if [ -d "$(LINUX_ARCH_HEADERS)/arch" ]; then \
> +             ln -s $(LINUX_ARCH_HEADERS)/arch debian/include ; \
> +     else \
> +             ln -s $(LINUX_HEADERS)/arch debian/include ; \
> +     fi

It seems /usr/include/<triplet>/arch is something tilegx specific, so it
means it will create a dead symlink on other architectures. Not sure
it will cause any arm, but it's not very nice.

Anyway don't need to submit a new patch, I think it's time to rewrite
this part of code with a for loop instead of adding many more similar
lines. I'll work on that.

Otherwise the patch looks fine to me.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurel...@aurel32.net                 http://www.aurel32.net

Reply via email to