Joe Orton
Fri, 23 May 2008 06:48:28 -0700
On Thu, May 15, 2008 at 05:17:00PM -0500, William Rowe wrote: > http://people.apache.org/~wrowe/ldap/apr-util-1.x-ldap.patch As expected, this breaks source compatibility, as defined by the APR versioning guidelines. The fact that you need to patch httpd to make httpd continue to build seems like ample demonstration that source compatibility is broken ;) So it's 2.x material, and because it's 2.x material the DSO stuff is unnecessary, the LDAP code can simply be moved into a separate library. Otherwise: - surprisingly simple patch, kudos - the pool lifetime stuff is probably dodgy because in 1.3.x you can now create unparented pools, i.e., there's no longer any guarantee that following pool->parent gets you to the APR global pool which lasts for the lifetime is the process. (who knows what else that new misfeature may break) - mingling the autofoo in with the DBD autofoo is obviously ugly ;) joe