Re: svn commit: r682369 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

[Mladen Turk]

Jim Jagielski wrote:

On Aug 4, 2008, at 9:54 AM, Ruediger Pluem wrote:

On 08/04/2008 03:50 PM, Mladen Turk wrote:

[EMAIL PROTECTED] wrote:

--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)

+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Mon Aug 4 05:53:50 2008

@@ -1380,7 +1380,6 @@
    proxy_worker *worker = (proxy_worker *)theworker;
    if (worker->cp->res) {
        worker->cp->pool = NULL;
-        apr_reslist_destroy(worker->cp->res);
    }
    return APR_SUCCESS;
}

Well, you've beat me :)
The complete conn_pool_cleanup function can be omitted, and
there is no need for checking  if (conn->worker->cp->pool)
in the connection_destructor.

Might be. At the current state it makes it possible to keep
trunk and 2.2.x very similar until all in apr land is sorted
out. We can cleanup the remaining parts then.

+1. Let's wait until APR gets sorted out before we start
mucking around with "fixing" 2.2 and trunk to handle an
in-flux APR

If the under the hood apr_reslist behavior is of such
concern we can create apr_reslist_create_ex with some
param that will allow to specify the pool cleanup ordering
keeping everyone happy concerning backporting and still
allowing all the goodies.


Regards
--
^(TM)