[jira] Commented: (JCR-2482) Reduce number of compiler warning by adding @Override and generics where appropriate

[Felix Meschberger (JIRA)]

    [ 
https://issues.apache.org/jira/browse/JCR-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828985#action_12828985
 ] 

Felix Meschberger commented on JCR-2482:
----------------------------------------

There is probably more to it, than just some syntax.

For the @Override it helps the compiler ensure correct extension. It is much 
simpler fixing issues occurring at compile time than to write tests and try to 
find issues at test/run time. Second it helps identifying overwritten methods 
when looking at the source without an IDE, e.g. by just skimming SVN with a 
browser.

For final: It serves AFAICT two purposes. One it helps preventing overwriting 
values inadvertedly, thus going into the "find bugs at compile time" category 
as the @Override annotation. The other use it might help compilers and vms 
optimizie the variable (though this may be of less importance nowadays with 
advanced compilers and modern VMs).

So, I think it is a good thing to have them.

> Reduce number of compiler warning by adding @Override and generics where 
> appropriate 
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-2482
>                 URL: https://issues.apache.org/jira/browse/JCR-2482
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi
>    Affects Versions: 2.1.0
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 2.1.0
>
>
> Add @Override and generics where possible to reduce the number of warnings 
> issued by the compiler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.