Am 2017-05-13 um 23:39 schrieb Michael Osipov:
Am 2017-05-13 um 22:38 schrieb Hervé BOUTEMY:
Le samedi 13 mai 2017, 00:58:45 CEST Michael Osipov a écrit :
Am 2017-05-13 um 00:30 schrieb Hervé BOUTEMY:
Le vendredi 12 mai 2017, 13:50:37 CEST Michael Osipov a écrit :
Am 2017-05-12 um 08:25 schrieb Hervé BOUTEMY:
Jenkins build is not flaky: it is strict on dependency resolution
from
cache, which is an intent, not a bug
This pretty much explains why a lot of ITs fail here at work with a
empty repo. I will to work this through.
beware to not make the ITs fail with previous Maven versions
All I did is this:
https://github.com/apache/maven-integration-testing/commit/5c01864e44c7c96ca
c95545e8568acd044b6d7dc
ok, just tested with Maven 3.0.5: this does not add more failures
(notice that
existing failures show we already did some mistakes in the past
regarding some
updated ITs...)
I reran Maven 3.5.0, 3.3.9 on Core ITs master on two operating systems.
Both pass. Then I ran 3.0.5, it fails just like you noticed. Except one
failure, this is due to the embedded mode. Several ITs are not
wellsuited for embedded mode (single VM).
The single in 3.0.5 is in MavenITmng0947OptionalDependencyTest. You
might remember that I have done recently some improvements to "optional"
in Core as well es to Core IT Support plugins: MNG-6229. It now payed
off. The optional flag was missing on the dep tree output, so the test
was impcomplete. Now, an issue has been detected in 3.0.5 or the IT itself:
Actual:
[INFO] [MAVEN-CORE-IT-LOG] Dumping artifact list:
D:\Entwicklung\Projekte\maven-integration-testing\core-it-suite\target\test-classes\mng-0947\target\compile.txt
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:e:jar:0.1
(optional)
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:d:jar:0.1
[INFO]
[INFO] --- maven-it-plugin-dependency-resolution:2.1-SNAPSHOT:runtime
(test) @ consumer ---
[INFO] [MAVEN-CORE-IT-LOG] Dumping artifact list:
D:\Entwicklung\Projekte\maven-integration-testing\core-it-suite\target\test-classes\mng-0947\target\runtime.txt
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:c:jar:0.1
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:e:jar:0.1
(optional)
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:d:jar:0.1
[INFO]
[INFO] --- maven-it-plugin-dependency-resolution:2.1-SNAPSHOT:test
(test) @ consumer ---
[INFO] [MAVEN-CORE-IT-LOG] Dumping artifact list:
D:\Entwicklung\Projekte\maven-integration-testing\core-it-suite\target\test-classes\mng-0947\target\test.txt
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:c:jar:0.1
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:e:jar:0.1
(optional)
[INFO] [MAVEN-CORE-IT-LOG] org.apache.maven.its.mng0947:d:jar:0.1
Expected:
List<String> compile = verifier.loadLines(
"target/compile.txt", "UTF-8" );
assertTrue( compile.toString(), compile.contains(
"org.apache.maven.its.mng0947:d:jar:0.1 (optional)" ) );
assertTrue( compile.toString(), compile.contains(
"org.apache.maven.its.mng0947:e:jar:0.1 (optional)" ) );
assertEquals( 2, compile.size() );
List<String> runtime = verifier.loadLines(
"target/runtime.txt", "UTF-8" );
assertTrue( runtime.toString(), runtime.contains(
"org.apache.maven.its.mng0947:c:jar:0.1" ) );
assertTrue( runtime.toString(), runtime.contains(
"org.apache.maven.its.mng0947:d:jar:0.1 (optional)" ) );
assertTrue( runtime.toString(), runtime.contains(
"org.apache.maven.its.mng0947:e:jar:0.1 (optional)" ) );
assertEquals( 3, runtime.size() );
List<String> test = verifier.loadLines( "target/test.txt",
"UTF-8" );
assertTrue( test.toString(), test.contains(
"org.apache.maven.its.mng0947:c:jar:0.1" ) );
assertTrue( test.toString(), test.contains(
"org.apache.maven.its.mng0947:d:jar:0.1 (optional)" ) );
assertTrue( test.toString(), test.contains(
"org.apache.maven.its.mng0947:e:jar:0.1 (optional)" ) );
assertEquals( 3, test.size() );
I need to have a closer look at it through the Maven versions.
Tackled it. Any objections to merge
44ae63380768e53fab11ffb73131f201b268ed81 on Core ITs?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
