Pls give me time to read it. On Sat, Jun 10, 2017 at 11:06 AM, Benedikt Ritter <brit...@apache.org> wrote:
> Hey guys, > > any thoughts on this? > > Benedikt > > Benedikt Ritter <brit...@apache.org> schrieb am Do. 8. Juni 2017 um 15:16: > > > Hello, > > > > first of all, I’d like to apologize for not being very active over the > > past few months. I’ve been busy at work and there was ApacheCON… so you > > know how it is :-) > > > > I’d like to take some time to review where we’re standing with JUnit 5 > > support and what we our next steps will be. Currently the whole thing is > a > > little bit messed up and I’m pretty much to blame for this: > > > > - we have a junit5 branch, where I started to implement some integration > > tests for JUnit 5 support. There are no code changes to Surefire itself > in > > this branch. It just tests that specifying the provider explicitly does > > work as shown in the JUnit docs. > > - then we have 3.0-rc1. We have merged the Provider code from the JUnit > > team into this branch. But we don’t have any tests there. > > - I’ve created a new PR to get work started on a ProviderInfo > > implementation to enable automatic provider lookup [1]. This way users > > don’t need to specify the provider explicitly anymore. > > > > So what should be our next steps? > > > > I think we should merge the junit5 branch into the 3.0-rc1 branch, so > that > > we have the existing integration tests we already implemented in place > for > > getting the work on the ProviderInfo started. > > Then we will need some time to clean up the integration test project. I > > think it need to be restructured a little bit to make it easier to > > understand and make it possible to run tests against several JUnit > versions. > > In the end we should be able to verify that all existing JUnit 4 also > work > > with the JUnit 5 provider. > > > > @Tibor: Can you merge the junit5 branch to 3.0-rc1 branch? Or should I > > create a PR for this? > > > > Best regards, > > Benedikt > > > > [1] https://github.com/apache/maven-surefire/pull/153 > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Cheers Tibor
