Unless I'm blind again, I can't see how 3rd party modules that use Apache C API can build when a threaded perl is used with mod_perl 1.0. In the current cvs, "apache_inc.h" doesn't get included at all with -DPERL_THREADS and therefore the build fails. Spotted with Apache::Scoreboard.

Please tell me whether this patch breaks anything before I commit it.
It's quite possible that nobody has tried to build 3rd party modules that use Apache C API with threaded perl, unless I miss something.

Index: src/modules/perl/mod_perl.h
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.h,v
retrieving revision 1.116
diff -u -r1.116 mod_perl.h
--- src/modules/perl/mod_perl.h 23 May 2002 04:35:16 -0000 1.116
+++ src/modules/perl/mod_perl.h 27 Dec 2002 02:12:48 -0000
@@ -72,11 +72,8 @@
#endif

#ifdef PERL_THREADS
-#define _INCLUDE_APACHE_FIRST
-#endif
-
-#ifdef _INCLUDE_APACHE_FIRST
#include "apache_inc.h"
+#define _INCLUDE_APACHE_FIRST
#endif

#include "EXTERN.h"


__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to