what it really does, is manipulating an internal Apache struct, hence I suggested to have a tracing option which will show only traces that affect Apache internal structs. e.g. tracing the mod of document_root sounds like a good example which will fit the MP_TRACE_a category
ok, MP_TRACE_a it is, then.
actually, I kind of like it - if we use it for places where we add logic behind what would otherwise be raw ap* calls, that would be very nice to have.
cool.
cool++
patch attached.
--Geoff
Index: lib/ModPerl/Code.pm
===================================================================
RCS file: /home/cvspublic/modperl-2.0/lib/ModPerl/Code.pm,v
retrieving revision 1.112
diff -u -r1.112 Code.pm
--- lib/ModPerl/Code.pm 23 Oct 2003 19:46:42 -0000 1.112
+++ lib/ModPerl/Code.pm 28 Oct 2003 15:59:42 -0000
@@ -451,7 +451,7 @@
}
my %trace = (
-# 'a' => 'all',
+ 'a' => 'Apache API interaction',
'c' => 'configuration for directive handlers',
'd' => 'directive processing',
'e' => 'environment variables',
@@ -481,13 +481,13 @@
#define MP_TRACE_OPTS "$opts"
#ifdef MP_TRACE
-#define MP_TRACE_a if ($tl) modperl_trace
-#define MP_TRACE_a_do(exp) if ($tl) { \\
+#define MP_TRACE_any if ($tl) modperl_trace
+#define MP_TRACE_any_do(exp) if ($tl) { \\
exp; \\
}
#else
-#define MP_TRACE_a if (0) modperl_trace
-#define MP_TRACE_a_do(exp)
+#define MP_TRACE_any if (0) modperl_trace
+#define MP_TRACE_any_do(exp)
#endif
EOF
Index: src/modules/perl/modperl_log.c
===================================================================
RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/modperl_log.c,v
retrieving revision 1.9
diff -u -r1.9 modperl_log.c
--- src/modules/perl/modperl_log.c 23 Sep 2003 08:04:42 -0000 1.9
+++ src/modules/perl/modperl_log.c 28 Oct 2003 15:59:42 -0000
@@ -74,5 +74,5 @@
modperl_trace_logfile_set(s->error_log);
- MP_TRACE_a_do(MP_TRACE_dump_flags());
+ MP_TRACE_any_do(MP_TRACE_dump_flags());
}--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
