my %trace = ( -# 'a' => 'all', + 'a' => 'Apache API interaction',
Ah, sorry, I forgot that 'a' is taken by 'all'. I can't think of another good choice. In which case how about 'p' for aPache?
actually, I thought all was 'a' too, but it doesn't look that way. if I do a preamble 'PerlTrace a' I don't get anything, and MP_TRACE_a only exists in 1 place (below). 'all' is mapped to MP_debug_level 0xffffffff
- MP_TRACE_a_do(MP_TRACE_dump_flags()); + MP_TRACE_any_do(MP_TRACE_dump_flags());
So, did you change s/all/any/?
this is the only occurence.
I think MP_TRACE_a (and the above variant) designates tracing that should happen as long as there is _some_ (or 'any' :) trace enabled. the autogenerated code (current) looks like this
#define MP_TRACE_OPTS "cdefghimost"
#define MP_TRACE_a if (MP_debug_level) modperl_trace
#define MP_TRACE_c if (MP_debug_level & 1) modperl_trace
so, I took over 'a' and changed the only _a to _any. I think it's a bit better this way but if you want to use 'p' instead, that's fine. it's no biggie.
Thanks Geoff. I looked some more at it:
We have 'all' which sets all levels and it won't clash with 'a'.
We have 'any' which is set when any level is set (coded as _a, you changed it to _any which is even better).
So I think your original patch is just fine. +1 to commit, perhaps committing it in parts (_a => _any first, then adding support for 'a').
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
