Re: Apache::SizeLimit + solaris Update 10

[Adam Prime]

Third time's a charm right?

Patches revised again.  The svn patch has now actually been tested on 
solaris with osvers of 2.10, and all the tests pass.

waiting 60 seconds for server to start: ok (waited 2 secs)
server localhost:8529 started
t/apache/all......................skipped: (no reason given)
t/apache2/basic...................ok
t/apache2/check_n_requests2.......ok
t/apache2/deprecated..............ok
t/apache2/zzz_check_n_requests....ok
t/pod.............................ok
All tests successful.
Files=6, Tests=18,  8 wallclock secs ( 0.04 usr  0.04 sys +  1.50 cusr 
0.31 csys =  1.89 CPU)
Result: PASS

# perl -V
Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
  Platform:
    osname=solaris, osvers=2.10, archname=i86pc-solaris
    uname='sunos fxbuild-i386 5.10 generic_127112-11 i86pc i386 i86pc 
solaris '
    config_args='-Dcc=gcc -Dprefix=/oanda/system'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef use5005threads=undef useithreads=undef 
usemultiplicity=undef
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef

Adam


Adam Prime wrote:
As soon as a got in bed last night i realized the conditional logic in
the original patches was wrong, corrected versions are attached.

Adam


Adam Prime wrote:
There was a thread today on the users list where a guy was running into
problems with SizeLimit on Solaris update 10 [1].  Attached are 2
patches, one against the version of Apache2::SizeLimit in the 2.04
distribution, and the other against the version in SVN.  the SVN version
still tests fine on linux, but I can't test it on solaris at home, and
the solaris boxes I do have access to don't have update 10 on them.

I'm also not sure if what I did is acceptable or not, but it should
work, I think.  I also didn't make the change in the 1.3 tree.

Adam

[1] http://marc.info/?t=123630641100001&r=1&w=2


------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org


------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org

Index: Core.pm
===================================================================
--- Core.pm	(revision 750777)
+++ Core.pm	(working copy)
@@ -131,7 +131,8 @@
 }
 
 BEGIN {
-    if ($Config{'osname'} eq 'solaris' && $Config{'osvers'} >= 2.6 ) {
+    my ($major,$minor) = split('\.',$Config{'osvers'});
+    if ($Config{'osname'} eq 'solaris' && ($major > 2 || $major == 2 && $minor >= 6)) {
         *_platform_check_size   = \&_solaris_2_6_size_check;
         *_platform_getppid = \&_perl_getppid;
     }
--- SizeLimit.pm.orig	2009-03-06 01:19:31.000000000 -0500
+++ SizeLimit.pm	2009-03-06 08:54:24.000000000 -0500
@@ -52,7 +52,8 @@
         if Apache2::MPM->is_threaded();
 
     # decide at compile time how to check for a process' memory size.
-    if (SOLARIS && $Config{'osvers'} >= 2.6) {
+    my ($major,$minor) = split('\.',$Config{'osvers'});
+    if (SOLARIS && ($major > 2 || $major == 2 && $minor >= 6)) {
 
         $HOW_BIG_IS_IT = \&solaris_2_6_size_check;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org