Re: Apache::SizeLimit + solaris Update 10

[Adam Prime]

Fred Moyer wrote:
On Wed, Mar 18, 2009 at 7:14 PM, Adam Prime <adam.pr...@utoronto.ca> wrote:
Fred suggested in resend these patches relative to the root of the
distributions, so here they are.  SizeLimit.patch is against the version
of Apache2::SizeLimit in mod_perl 2.0.4 and generated via git diff.
svn.SizeLimit.patch is against the version of SizeLimit in svn, and was
generated with svn diff.

This git diff doesn't match what I have in svn trunk for
Apache2/SizeLimit.pm, 

Thats because it's against the version in mod_perl 2.0.4, which is 
nothing like the version that currently in svn.

applied to your second part of the patch.  I'd like to see the
$major/$minor logic use a couple of more parentheses to spell out
exactly what it is doing without having to worry about whether the
conditional parser in my head is interpreting this conditional
correctly.

Do you want me to resubmit it like :

   (($major > 2) || ($major == 2 && $minor >= 6))

I'm guessing that's what you mean.

Adam


Index: lib/Apache/SizeLimit/Core.pm
===================================================================
--- lib/Apache/SizeLimit/Core.pm        (revision 755867)
+++ lib/Apache/SizeLimit/Core.pm        (working copy)
@@ -131,7 +131,11 @@
 }

 BEGIN {
-    if ($Config{'osname'} eq 'solaris' && $Config{'osvers'} >= 2.6 ) {
+     my ($major,$minor) = split('.',$Config{'osvers'});
+
+     if ($Config{'osname'} eq 'solaris' &&
+         ($major > 2 || $major == 2 && $minor >= 6)) {
+
         *_platform_check_size   = \&_solaris_2_6_size_check;
         *_platform_getppid = \&_perl_getppid;




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org