[ 
https://issues.apache.org/jira/browse/SLING-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962835#comment-15962835
 ] 

Bertrand Delacretaz commented on SLING-6763:
--------------------------------------------

Thanks for your contribution! 

The {{sling-babel.js}} file is quite long and looks like it might have been 
generated, as opposed to handwritten code, could you briefly explain what it's 
about and if generated how that happens?

Also, I don't see any changes under src/test which might indicate "suboptimal" 
test coverage, is there a way to test these new features? Does the demo package 
allows for doing that manually? If yes that's ok as a temporary state until 
there's stronger test coverage, which we should have before releasing this 
module.

> Remove org.apache.sling.commons.json dependency from esx engine
> ---------------------------------------------------------------
>
>                 Key: SLING-6763
>                 URL: https://issues.apache.org/jira/browse/SLING-6763
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Apache Sling Scripting ESX 0.2.0
>            Reporter: Senol Tas
>            Assignee: Bertrand Delacretaz
>
> remove org.apache.sling.commons.json dependency from esx engine and replace 
> with native build in nashorn JSON parser
> + minor updates in the demo package to showcase the usage of dynamically 
> changing handlebars templates based on selector.
> + added experimental es6 transpiler as preperation for sandboxing the engine
> + updated demo with es6 classes and imports
> i created a pull request on github:
> https://github.com/apache/sling/pull/209



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to