I might have hit send too early - could you please rollback your changes from trunk?
On Fri, 19 May 2017 at 11:53 Radu Cotescu <r...@apache.org> wrote: > Hi Dan, > > That's where the problem is - your Maven instance seems to be picking a > different artifact version than what was officially released the last time: > 2.2.6-53compat. > > Cheers, > Radu > > On Thu, 18 May 2017 at 22:01 Daniel Klco <dk...@apache.org> wrote: > >> Radu, >> >> Totally fair. When I roll back to r1795539, I see the following in the >> baseline report: >> >> https://gist.github.com/klcodanr/43625af985e2524892c6994c20e8c50f >> >> Thanks, >> Dan >> >> On Thu, May 18, 2017 at 12:31 PM, Radu Cotescu <r...@apache.org> wrote: >> >> > Hi Dan, >> > >> > Could you please post the report of the baseline plugin before your >> commit? >> > >> > At r1795516 I have this: >> > >> > [INFO] Comparing bundle org.apache.sling.scripting.jsp.taglib version >> > 2.2.7-SNAPSHOT to version 2.2.6 >> > [INFO] >> > [INFO] PACKAGE_NAME DELTA >> > CUR_VER BASE_VER REC_VER WARNINGS >> > [INFO] = ================================================== ========== >> > ========== ========== ========== ========== >> > [INFO] org.apache.sling.scripting.jsp.taglib unchanged >> > 2.2.0 2.2.0 2.2.0 - >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [INFO] org.apache.sling.scripting.jsp.taglib.helpers unchanged >> > 2.2.0 2.2.0 2.2.0 - >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [INFO] org.apache.sling.scripting.jsp.taglib.tei unchanged >> > 2.2.0 2.2.0 2.2.0 - >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [INFO] Baseline analysis complete, 0 error(s), 0 warning(s) >> > >> > >> > After your commit I see: >> > >> > [INFO] PACKAGE_NAME DELTA >> > CUR_VER BASE_VER REC_VER WARNINGS >> > [INFO] = ================================================== ========== >> > ========== ========== ========== ========== >> > [INFO] org.apache.sling.scripting.jsp.taglib unchanged >> > 2.3.0 2.2.0 2.2.0 Version has been increased but >> analysis >> > detected no changes >> > [INFO] - version 2.2.0 >> > [INFO] + version 2.3.0 >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [INFO] org.apache.sling.scripting.jsp.taglib.helpers unchanged >> > 2.2.0 2.2.0 2.2.0 - >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [INFO] org.apache.sling.scripting.jsp.taglib.tei unchanged >> > 2.2.0 2.2.0 2.2.0 - >> > [INFO] >> > ------------------------------------------------------------ >> > ----------------------------------------------- >> > [WARNING] org.apache.sling.scripting.jsp.taglib: Excessive version >> > increase; detected 2.3.0, suggested 2.2.0 >> > [WARNING] org.apache.sling.scripting.jsp.taglib: Version has been >> > increased >> > but analysis detected no changes; detected 2.3.0, suggested 2.2.0 >> > [INFO] Baseline analysis complete, 0 error(s), 2 warning(s) >> > >> > >> > I'd really like us to avoid increasing API versions without a good >> reason. >> > >> > Thanks, >> > Radu >> > >> > On Thu, 18 May 2017 at 16:38 <dk...@apache.org> wrote: >> > >> > > Author: dklco >> > > Date: Thu May 18 14:38:40 2017 >> > > New Revision: 1795540 >> > > >> > > URL: http://svn.apache.org/viewvc?rev=1795540&view=rev >> > > Log: >> > > Fixing baseline issues about the versioning of JSP Taglibs >> > > >> > > Modified: >> > > sling/trunk/bundles/scripting/jsp-taglib/pom.xml >> > > >> > > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/ >> > apache/sling/scripting/jsp/taglib/package-info.java >> > > >> > > Modified: sling/trunk/bundles/scripting/jsp-taglib/pom.xml >> > > URL: >> > > http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/ >> > jsp-taglib/pom.xml?rev=1795540&r1=1795539&r2=1795540&view=diff >> > > >> > > ============================================================ >> > ================== >> > > --- sling/trunk/bundles/scripting/jsp-taglib/pom.xml (original) >> > > +++ sling/trunk/bundles/scripting/jsp-taglib/pom.xml Thu May 18 >> 14:38:40 >> > > 2017 >> > > @@ -20,7 +20,7 @@ >> > > </parent> >> > > >> > > <artifactId>org.apache.sling.scripting.jsp.taglib</artifactId> >> > > - <version>2.2.7-SNAPSHOT</version> >> > > + <version>2.3.0-SNAPSHOT</version> >> > > <packaging>bundle</packaging> >> > > >> > > <name>Apache Sling JSP Tag Library</name> >> > > >> > > Modified: >> > > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/ >> > apache/sling/scripting/jsp/taglib/package-info.java >> > > URL: >> > > http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/ >> > jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/ >> > taglib/package-info.java?rev=1795540&r1=1795539&r2=1795540&view=diff >> > > >> > > ============================================================ >> > ================== >> > > --- >> > > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/ >> > apache/sling/scripting/jsp/taglib/package-info.java >> > > (original) >> > > +++ >> > > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/ >> > apache/sling/scripting/jsp/taglib/package-info.java >> > > Thu May 18 14:38:40 2017 >> > > @@ -16,7 +16,7 @@ >> > > * specific language governing permissions and limitations >> > > * under the License. >> > > */ >> > > -@Version("2.2.0") >> > > +@Version("2.3.0") >> > > package org.apache.sling.scripting.jsp.taglib; >> > > >> > > import aQute.bnd.annotation.Version; >> > > \ No newline at end of file >> > > >> > > >> > > >> > >> >
