[
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130328#comment-16130328
]
Robert Munteanu edited comment on SLING-6519 at 8/17/17 12:38 PM:
------------------------------------------------------------------
Unfortunately this seems to always fail when connecting in debug mode. I get an
error which looks like
{noformat}java.lang.IllegalStateException: Expected a name but was BEGIN_OBJECT
at line 1 column 3
at com.google.gson.stream.JsonReader.nextName(JsonReader.java:785)
at
org.apache.sling.ide.osgi.impl.HttpOsgiClient.findSourceReferences(HttpOsgiClient.java:252)
at
org.apache.sling.ide.osgi.impl.TracingOsgiClient.findSourceReferences(TracingOsgiClient.java:110)
at
org.apache.sling.ide.eclipse.core.internal.JVMDebuggerConnection.connectInDebugMode(JVMDebuggerConnection.java:120)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:123)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
at
org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
at
org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
at
org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){noformat}
I'll try and provide a test + fix shortly.
_Edit_: typo
was (Author: rombert):
Unfortunately this seems to always fail when connecting in debug mode. I get an
error which looks like
{noformat}java.lang.IllegalStateException: Expected a name but was BEGIN_OBJECT
at line 1 column 3
at com.google.gson.stream.JsonReader.nextName(JsonReader.java:785)
at
org.apache.sling.ide.osgi.impl.HttpOsgiClient.findSourceReferences(HttpOsgiClient.java:252)
at
org.apache.sling.ide.osgi.impl.TracingOsgiClient.findSourceReferences(TracingOsgiClient.java:110)
at
org.apache.sling.ide.eclipse.core.internal.JVMDebuggerConnection.connectInDebugMode(JVMDebuggerConnection.java:120)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:123)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
at
org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
at
org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
at
org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){noformat}
I'll try and provided a test + fix shortly.
> Remove dependency to org.json
> -----------------------------
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
> Issue Type: Improvement
> Components: IDE
> Reporter: Carsten Ziegeler
> Assignee: Robert Munteanu
> Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6519-v01.patch
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
> org.json.JSONArray;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
> org.json.JSONObject;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import
> org.json.JSONObject;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
