Hi guys, I was trying to investigate what really happens, but in the last days I have had no much free-time. Rather I would say: let's see what really causes the problem and let's try to preserve the backward compatibility before considering to apply Lukasz's patch. Furthermore I would downgrade the issue's priority to minor (IMHO is a rare case).
WDYT? On 5 July 2011 16:48, Wesley Wannemacher <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1003/#review960 > ----------------------------------------------------------- > > > Lukasz, I'm not sure what makes this change backwards incompatible... I > would say "ship it" but I'm more curious about why moving this to the > closing template would make a difference. One thing that I noticed about the > original issue is that the poster is setting the variable in "page" scope, > then attempting to access the variable from another page that is included. I > haven't spent time looking at the example war that the poster attached, but > I will say this - I don't have a problem with this change, but I might have > a problem with the motivation for making the change and I would also want to > look closer at our UIBean and ClosingUIBean if the opening template is > rendered differently than the closing template. > > - Wesley > > > On 2011-07-05 14:01:47, Lukasz Lenart wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/1003/ > > ----------------------------------------------------------- > > > > (Updated 2011-07-05 14:01:47) > > > > > > Review request for Struts2. > > > > > > Summary > > ------- > > > > This change will solve https://issues.apache.org/jira/browse/WW-3659 but > can be backward incompatibile > > > > > > Diffs > > ----- > > > > ./core/src/main/resources/template/simple/a-close.ftl 1141925 > > ./core/src/main/resources/template/simple/a.ftl 1141925 > > > > Diff: https://reviews.apache.org/r/1003/diff > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Lukasz > > > > > > -- Maurizio Cucchiara
