Yes that how it is currently, just semantically I think it would be better to have all the PDU assembly/disassembly functions in one place.
It may also benefit others in future to have compatible pack/unpack functions out the box. On Saturday, 24 September 2016, Rene Kluwen <rene.klu...@chimit.nl> wrote: > Sure, but why not change KSMPPD to use smpp_pdu_pack() function without > the length? > > > > == Rene > > > > > > *Van:* devel [mailto:devel-boun...@kannel.org > <javascript:_e(%7B%7D,'cvml','devel-boun...@kannel.org');>] *Namens *Donald > Jackson > *Verzonden:* zaterdag 24 september 2016 12:07 > *Aan:* kannel_dev_mailinglist <devel@kannel.org > <javascript:_e(%7B%7D,'cvml','devel@kannel.org');>> > *Onderwerp:* [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c > > > > Hi all, > > > > Currently KSMPPD runs a patch against Kannel SVN trunk, I believe it would > be better if we could just include this patch in the mainline Kannel as > they don't have any negative implications. > > > > Currently the smpp_pdu_unpack() function takes data without length but the > smpp_pdu_pack() function provides length so these two functions are not > compatible with each other. This simple patch just allows for > compatibility convenience. > > > > Thanks, > > Donald > -- Donald Jackson http://www.elite-sms-software.com http://www.ddj.co.za http://www.thearchitech.com donald(a)thearchitech.com
