Hi Paul,

while looking at MM7 implementation code and escpecially at
mmlib/mms_strings.c (tried to understand once again (C) Lars Wirzenius
preprocessor tricks), I found some minors bugs. Diff attached.

Btw, are there any plans to implement VASP authorization for MM4?
Another approach would be to unify these credentials (wrote about this
some time ago). I'm thinking about a patch which would make a
possibility to authorize VASP's calling some external module (which
would query DB for example). I think it's important because operator
often has lots of duplicates of the same VASP (for each SMPP, MM MM7,
MM MM4, PPG etc. connection).

On 4/14/05, Paul Bagyenda <[EMAIL PROTECTED]> wrote:
> Thanks Dziugas,
> 
>  As I understand it, sf.net anonymous cvs is a couple of hours behind
> the developer one. Give it sometime and the changes should be visble.
> Otherwise my cvs would be lying to me :)
> 
> 
> On Apr 14, 2005, at 15:19, Dziugas Baltrunas wrote:
> 
> > Hi Paul,
> >
> > congratulations once again for such a useful feature implementation!
> >
> > It seems that Sourceforge again has long delays or you forgot to
> > commit the changes, because MM7 changes are missing (at least
> > doc/userguide.shtml and some others).
> >
> > On 4/14/05, Paul Bagyenda <[EMAIL PROTECTED]> wrote:
> >> CVS has been updated with our first implementation of MMS VAS support
> >> in Mbuni.
> >>
> >>  The short story:
> >>    Mbuni now supports sending and receiving MMS via the MM7/SOAP
> >> protocol as specified in 3GPP 23.140. Get CVS and play.
> >>
> >> The longer story:
> >>   In the config file for mbuni (cvs version that is) you can define
> >> one
> >> or more value added services providers (VASPs). The userguide (found
> >> in
> >> the doc/ directory) explains how to do this. (A sample config file
> >> sent.) Mbuni will then accept messages from VASPs and send them on,
> >> and
> >> will also send messages to VASPs when received.
> >>
> >>  Since this required yet more changes to Kannel, you must first patch
> >> and install Kannel before compiling Mbuni. (Patch file is in directory
> >> misc-patches/.) Specifically, we updated the Kannel config file format
> >> to include the new directives, and also added a new function to
> >> mime.[ch] (existing ones were somewhat broken).
> >>
> >> For testing purposes, the Openwave MMS SDK (found at
> >> http://developer.openwave.com/dvl/tools_and_sdk/openwave_mobile_sdk/
> >> mms_sdk/) is useful. It also comes with the actual source code (very
> >> useful, since the supplied lib -- vaspapi.jar -- has a bug or two).
> >> The
> >> SonyEricsson lib seems a bit limited...
> >>
> >> Next we plan to implement the EAIF interface, while we clean-up the
> >> SOAP code. Very good feedback has been received on the mmbox code, and
> >> a number of fixes have been done in the meantime. All on cvs.
> >>
> >> Please send feedback. Lets hope no bugs were introduced :)
> >>
> >> Cheers
> >>
> >> Paul
> >>
> >> PS: cvs browsing: http://cvs.sourceforge.net/viewcvs.py/mbuni/mbuni/
> >>
> >> _______________________________________________
> >> Devel mailing list
> >> Devel@mbuni.org
> >> http://mbuni.org/mailman/listinfo/devel_mbuni.org
> >>
> >
> >
> > --
> > Dziugas
> >
> > _______________________________________________
> > Devel mailing list
> > Devel@mbuni.org
> > http://mbuni.org/mailman/listinfo/devel_mbuni.org
> >
> 
> _______________________________________________
> Devel mailing list
> Devel@mbuni.org
> http://mbuni.org/mailman/listinfo/devel_mbuni.org
> 


-- 
Dziugas
? mmlib/.deps
? mmlib/Makefile
? mmsc/.deps
? mmsc/Makefile
Index: mmlib/mms_strings.c
===================================================================
RCS file: /cvsroot/mbuni/mbuni/mmlib/mms_strings.c,v
retrieving revision 1.2
diff -u -r1.2 mms_strings.c
--- mmlib/mms_strings.c 23 Mar 2005 05:55:16 -0000      1.2
+++ mmlib/mms_strings.c 14 Apr 2005 20:02:07 -0000
@@ -18,11 +18,6 @@
  * Adapted from wsp_strings.c
  */
 
-#include "gwlib/gwlib.h"
-
-#include "mms_strings.h"
-
-
 #define TABLE_SIZE(table) ((long)(sizeof(table) / sizeof(table[0])))
 
 static int initialized;
Index: mmlib/mms_strings.h
===================================================================
RCS file: /cvsroot/mbuni/mbuni/mmlib/mms_strings.h,v
retrieving revision 1.4
diff -u -r1.4 mms_strings.h
--- mmlib/mms_strings.h 7 Apr 2005 12:21:35 -0000       1.4
+++ mmlib/mms_strings.h 14 Apr 2005 20:02:07 -0000
@@ -29,7 +29,6 @@
 #include "mms_strings.def"
 
 
-#define LINEAR(name,strings)
 #define LINEAR(name, strings)
 #define STRING(string)
 #define NAMED(name, strings) enum mms_##name##_enum { strings 
mms_##name##_dummy };
Index: mmlib/mms_util.c
===================================================================
RCS file: /cvsroot/mbuni/mbuni/mmlib/mms_util.c,v
retrieving revision 1.19
diff -u -r1.19 mms_util.c
--- mmlib/mms_util.c    14 Apr 2005 11:27:22 -0000      1.19
+++ mmlib/mms_util.c    14 Apr 2005 20:02:08 -0000
@@ -52,7 +52,7 @@
          char sbuf[512];
          
          sprintf(sbuf, "_%s", symbolname);
-#endif;  
+#endif  
          if (x == NULL || ((y = dlsym(x, symbolname)) == NULL 
 #ifdef __APPLE__ /* fink version of dlsym has issues it seems. */
              && (y = dlsym(x, sbuf)) == NULL
Index: mmsc/mmsmobilesender.c
===================================================================
RCS file: /cvsroot/mbuni/mbuni/mmsc/mmsmobilesender.c,v
retrieving revision 1.10
diff -u -r1.10 mmsmobilesender.c
--- mmsc/mmsmobilesender.c      14 Apr 2005 14:45:48 -0000      1.10
+++ mmsc/mmsmobilesender.c      14 Apr 2005 20:02:09 -0000
@@ -459,7 +459,7 @@
      if (gwthread_create((gwthread_func_t *)receive_push_reply, httpcaller) < 
0) { /* Listener thread. */
          error(0, "Mobile sender: Failed to create push reply thread: %d: %s!",
                errno, strerror(errno));
-         return -1;
+         return;
      }
 
      mms_queue_run(octstr_get_cstr(settings->mm1_queuedir), 
@@ -468,7 +468,7 @@
      http_caller_signal_shutdown(httpcaller);
      sleep(2);
      http_caller_destroy(httpcaller);
-     return 0;     
+     return;     
 }
 
 
_______________________________________________
Devel mailing list
Devel@mbuni.org
http://mbuni.org/mailman/listinfo/devel_mbuni.org

Reply via email to