I agree that there's always an alternative - if "ifconfig" doesn't show the IRQ number, try /proc/interrupts; if "netdev->irq" is zero, try "to_pci_dev(&netdev->dev)->irq".
My point was that, though I could certainly live with the fact that e1000 driver wouldn't propagate net_device::irq, if otherwise there would be less workarounds of driver quirks in any code that needed to know a NIC's IRQ number - in my case, I need to choose a CPU node closer to a NIC to handle its IRQs in a NUMA system. It's not a big deal to look at pci_dev->irq if netdev->irq is zero and it's a PCI device; it just seemed more natural to me to add this one-liner to the e1000 driver. Thanks, Isaac On Tue, Sep 23, 2008 at 12:27:56PM -0700, Brandeburg, Jesse wrote: > it was getting stripped by the list handler. Inline is better. > > putting this in e1000 is maybe okay, but what are you trying to achieve? > you can get the data from /proc/interrupts just as easily. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
