From: [email protected]
To: [email protected]
Subject: RE: gladevcp patch -please review
Date: Fri, 3 Feb 2012 04:08:25 +0000








> can I ask you to have a look at this patch before I add it to v2.5_branch?
> 
> It works around a Gtk bug where Gladedbuilder files havent set their name 
> properly which is needed to properly support themes/gtkrc
> 
> 
> http://git.linuxcnc.org/gitweb?p=emc2.git;a=commit;h=f62708319375ce2f26dccd686692c270b495f4d3
> 
> please see also the example posted here:
> 
> http://www.linuxcnc.org/index.php/english/component/kunena/?func=view&catid=48&id=16439&limit=6&start=18#17332
> 
> thanks
> 
> Michael
> 
> 

I tried your patch and it seemed to work fine. -pretty cool!
But looking at the code I wonder if the -R option should be run before the -t 
theme change since
themes have rc files. It might not matter I didn't test this.

Also the docs should mention that your example will not work with all themes.
themes using pixmap engine render the states of (eg.) labels with different 
images.
You must have different colored images.
I am not an theme expert so there may be away around this - in fact in the 
Blue-Joy theme 
there is an option written for some widgets:       recolorable        = TRUE 
Though it does't seen to allow recoloring - If i add Blue-Joy them to your 
example it doesn't work.

I really wish you would change back the printed info about changing themes.
I had a them problem and could not find out if gladevcp was trying to change 
the theme or not.
I can see this as a common user problem and I see no reason to hide it from 
them.
by the way how do you enable debug messages?

Chris M

                                                                                
  
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to