On 12/05/13 00:25, Damyan Ivanov wrote:
> Already done. See
> http://patch-tracker.debian.org/patch/series/view/firebird2.5/2.5.2.26540.ds4-8/out/hardening.patch
>
Damyan, I dislike solution for gpre in this patch. In very many places
printa() is used to output strings - but in a few places it's replaced
after your patch with macro PUTSAT(). I agree it works but it's not good
style to have 2 different independent ways to do something in the program.
It's much better to use
printa(pos, "%s", line);
instead.
Not to mention we try to avoid preprocessor where possible and even from
this POV adding new macro is bad idea.
A.
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
