acumiskey
Fri, 18 Jul 2008 08:14:25 -0700
Author: acumiskey Date: Fri Jul 18 08:13:34 2008 New Revision: 677930 URL: http://svn.apache.org/viewvc?rev=677930&view=rev Log: Some minor optimizations and javadoc corrections. Modified: xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java Modified: xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java URL: http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java?rev=677930&r1=677929&r2=677930&view=diff ============================================================================== --- xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java (original) +++ xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java Fri Jul 18 08:13:34 2008 @@ -48,9 +48,9 @@ = new java.util.HashMap/*<Integer,DataObjectCache>*/(); - /** Mapping of data object uri --> cache entry */ - private Map/*<String,DataObjectCache.Entry>*/ cacheRecordMap - = new java.util.HashMap/*<String,DataObjectCache.Entry>*/(); + /** Mapping of data object uri --> cache record */ + private Map/*<ResourceInfo,DataObjectCache.Record>*/ recordMap + = new java.util.HashMap/*<ResourceInfo,DataObjectCache.Record>*/(); /** Used for create data objects */ private DataObjectFactory factory = new DataObjectFactory(); @@ -64,9 +64,6 @@ /** The temporary cache file */ private File tempFile; - /** The cache id */ - private int id; - /** The next file pointer position in the cache file */ private long nextPos; @@ -82,7 +79,7 @@ DataObjectCache cache = (DataObjectCache)cacheMap.get(cacheKey); if (cache == null) { try { - cache = new DataObjectCache(); + cache = new DataObjectCache(id); cacheMap.put(cacheKey, cache); } catch (IOException e) { log.error("Failed to create cache"); @@ -94,9 +91,10 @@ /** * Default constructor + * + * @param id the cache id */ - private DataObjectCache() throws IOException { - this.id = System.identityHashCode(Thread.currentThread()); + private DataObjectCache(int id) throws IOException { this.tempFile = File.createTempFile(CACHE_FILENAME_PREFIX + id, null); this.raFile = new RandomAccessFile(tempFile, "rw"); this.channel = raFile.getChannel(); @@ -123,7 +121,7 @@ */ public String put(DataObjectInfo dataObjectInfo) { ResourceInfo resourceInfo = dataObjectInfo.getResourceInfo(); - Record record = (Record)cacheRecordMap.get(resourceInfo); + Record record = (Record)recordMap.get(resourceInfo); if (record == null) { record = new Record(); AbstractNamedAFPObject dataObj = factory.createObject(dataObjectInfo); @@ -145,7 +143,7 @@ log.error("Failed to write cache record for '" + resourceInfo + "', " + e.getMessage()); } - cacheRecordMap.put(resourceInfo, record); + recordMap.put(resourceInfo, record); } return record.objectName; } @@ -157,7 +155,7 @@ * @return the binary data of the AbstractDataObject or null if failed. */ public byte[] get(ResourceInfo resourceInfo) { - Record record = (Record)cacheRecordMap.get(resourceInfo); + Record record = (Record)recordMap.get(resourceInfo); if (record == null) { throw new IllegalArgumentException("Unknown data object " + resourceInfo); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]