On Tue, Feb 14, 2017 at 10:06:34AM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > I'm not sure if this protection is necessary, but if it is, it doesn't > > get triggered if the symlink point directly to "../../dir3/other_ckout" > > since the "top of a checkout" check only happens for the recursive call. > > > > I believe this may be to protect against file system loops? > I don't think so, all the check does is to look for a _FOSSIL_ or a .fslckout file exist inside the specified directory.
> > > > I don't know if the top of a checkout *must* be skipped or not, but > > right now there's something inconsistent with this rule. > > > > I think it's by design. It does not appear to be directly related to > the symlinks issues. > True, the same issue happens when doing the "add" on a real directory. If a subdirectory inside is the top of a checkout, it will be *silently* skipped. I've also notice that the "extra" command ignore those "top of checkout" directories, just like the "add" command. So my understanding is that those "top of checkout" directory are ignored during scan, unless they are explicitly specified from command line. It does make sense to me now. May be it would be useful to have a verbose mode (-v) on some commands like "add" and "extra"? In verbose mode, those commands could print why some files or directory got skipped. Just an idea... Regards -- Martin G. _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
