Re: patch to make obexapp work with BSD iconv(3)

[Maksim Yevmenkin]

Matthias,

> Here is a patch which removes the GNU iconv dependency from obexapp.
> I've successfully tested it by sending vcards with strange names;
> the resulting files were identical.

thanks for the patch!

could you please tell me which bsd flavor you tested this on?

> The relevant changes are:
> -just use the result of nl_langinfo(CODESET) as input of
>  iconv_open(3), this is more robust than trying to interpret
>  the locale string
> -remove iconvctl(ICONV_SET_DISCARD_ILSEQ) -- BSD doesn't
>  have this and it should be unneeded because it only
>  compensates for some non-standard behaviour of GNU iconv.
> (The bsdxml->expat part is unrelated.)

i dont really have any objections to those, just wanted to get some
clarification.

thanks
max
_______________________________________________
freebsd-bluetooth@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth
To unsubscribe, send any mail to "freebsd-bluetooth-unsubscr...@freebsd.org"