Re: NEWCARD broken in -current

[Jesper Skriver]

On Wed, Mar 28, 2001 at 10:15:21PM +0200, Niels Chr. Bank-Pedersen wrote:
> On Wed, Mar 28, 2001 at 10:09:28PM +0200, Jesper Skriver wrote:
> > cc -c -O -pipe  -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  
>-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi  
>-nostdinc -I-  -I.  -I/usr/src/sys -I/usr/src/sys/dev -I/usr/src/sys/../include 
>-I/usr/src/sys/contrib/dev/acpica/Subsystem/Include  -D_KERNEL -include opt_global.h 
>-elf  -mpreferred-stack-boundary=2
> > /usr/src/sys/dev/pccbb/pccbb.c
> > In file included from /usr/src/sys/dev/pccbb/pccbb.c:56:
> > /usr/src/sys/sys/mutex.h:87: field `mtx_object' has incomplete type
> > /usr/src/sys/dev/pccbb/pccbb.c: In function `pccbb_detach':
> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of function 
>`MPASS'
> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of function 
>`LOCK_LOG_LOCK'
> > /usr/src/sys/dev/pccbb/pccbb.c:533: warning: implicit declaration of function 
>`WITNESS_LOCK'
> > /usr/src/sys/dev/pccbb/pccbb.c:539: warning: implicit declaration of function 
>`WITNESS_UNLOCK'
> > *** Error code 1
> 
> You'll need to #include <sys/types.h> and <sys/lock.h>
> in /usr/src/sys/dev/pccbb/pccbb.c

Right, the below fixes it, should I commit ?

Index: src/sys/dev/pccbb/pccbb.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
retrieving revision 1.12
diff -u -r1.12 pccbb.c
--- src/sys/dev/pccbb/pccbb.c   2001/02/09 06:08:52     1.12
+++ src/sys/dev/pccbb/pccbb.c   2001/03/28 20:51:20
@@ -53,6 +53,8 @@
 #include <sys/kernel.h>
 #include <sys/kthread.h>
 #include <sys/malloc.h>
+#include <sys/types.h>
+#include <sys/lock.h>
 #include <sys/mutex.h>
 
 #include <sys/bus.h>

/Jesper

-- 
Jesper Skriver, jesper(at)skriver(dot)dk  -  CCIE #5456
Work:    Network manager   @ AS3292 (Tele Danmark DataNetworks)
Private: FreeBSD committer @ AS2109 (A much smaller network ;-)

One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone to bind them.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message