On 9/3/06, Harald Dunkel <[EMAIL PROTECTED]> wrote:
Hi Renato,

seventh guardian wrote:
> On 9/3/06, Harald Dunkel <[EMAIL PROTECTED]> wrote:
>> Hi folks,
>>
>> Of course I haven't tried all different Linux distros. but
>> for Debian Etch I have to apply the appended patch to make
>> detecting "gdk-imlib11" work. "imlib11" (without "gdk-")
>> does not seem to be necessary. Imlib.h doesn't appear
>> anywhere in the code, except for acinclude.m4.
>
> You are changing what I believe is the test for Imlib. There is
> already a test for gdk_imlib bellow (which also includes gdk_imlib.h),
> but I don't know why it doesn't work for you..
>

On Debian (and Ubuntu?) imlib-dev and gdk-imlib-dev are seperate
packages, built from the same source package. They do not rely
upon each other, AFAICS. Same goes for the packages providing
the runtime libraries.

AFAICS fvwm doesn't make use of imlib, but of gdk-imlib. For
building and running fvwm you just need gdk-imlib-dev and
gdk-imlib.

But to make the tests in the unpatched acinclude.m4 succeed you
have to install both gdk-imlib-dev and imlib-dev, plus the
appropriate runtime library packages. IMHO this is not correct.

>> Is this patch OK? Could somebody please verify and apply?
>> Of course the patched fvwm built cleanly (at least on my
>> Debian box).
>>
>
> I think you are doing the wrong thing, as you are "tricking" the
> system to inclue gdk_imlib when it detects plain imlib. You should try
> to figure out why it isn't detecting gdk_imlib..
>

The patched acinclude.m4 _does_ detect gdk-imlib.  Imlib
(without "gdk-") is not installed on my PC, and yet I can
build and run fvwm including all features, as shown in a
previous post in this thread.

I see your point, and I agree that things may not be working
correctly. But what you did is a hack. You just changed the test
program to detect imlib when it is not there.

Even if it works that way, it should be done properly. Probably a
cleanup would be good.. There's a bunch of dup/unused code in that
file..

Cheers
 Renato

% ldd /usr/lib/fvwm/2.5.18/FvwmGtk
        libSM.so.6 => /usr/lib/libSM.so.6 (0x00002ae71a6d7000)
        libICE.so.6 => /usr/lib/libICE.so.6 (0x00002ae71a7e1000)
        libXext.so.6 => /usr/lib/libXext.so.6 (0x00002ae71a8fd000)
        libX11.so.6 => /usr/lib/libX11.so.6 (0x00002ae71aa0e000)
        libm.so.6 => /lib/libm.so.6 (0x00002ae71abe9000)
        libgtk-1.2.so.0 => /usr/lib/libgtk-1.2.so.0 (0x00002ae71ad6d000)
        libgdk-1.2.so.0 => /usr/lib/libgdk-1.2.so.0 (0x00002ae71afd3000)
        libgmodule-1.2.so.0 => /usr/lib/libgmodule-1.2.so.0 (0x00002ae71b111000)
        libglib-1.2.so.0 => /usr/lib/libglib-1.2.so.0 (0x00002ae71b215000)
        libdl.so.2 => /lib/libdl.so.2 (0x00002ae71b340000)
        libXi.so.6 => /usr/lib/libXi.so.6 (0x00002ae71b443000)
        libgdk_imlib.so.2 => /usr/lib/libgdk_imlib.so.2 (0x00002ae71b54c000)
        libc.so.6 => /lib/libc.so.6 (0x00002ae71b671000)
        libXau.so.6 => /usr/lib/libXau.so.6 (0x00002ae71b8ad000)
        libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x00002ae71b9b0000)
        /lib64/ld-linux-x86-64.so.2 (0x00002ae71a5bf000)
% dpkg-query -S libgdk_imlib.so.2
gdk-imlib11: /usr/lib/libgdk_imlib.so.2
gdk-imlib11: /usr/lib/libgdk_imlib.so.2.0.0


Regards

Harri






Reply via email to