Thomas Adam writes:
> On Sun, Jul 24, 2011 at 02:52:56PM -0600, Glenn Golden wrote:
> > I'm not implying there's anything wrong with this; just pointing it out,
> > because it confused me a little when I was testing it and toggling back
> > and forth between the two modes. It's entirely consistent with the change
> > in selection semantics for the subcase of a uniquely associated hotkey.
>
> This is actually desired behaviour, given the way the entire function
> surrounding the code-change has been written.
>
Agree. As I said, only pointing it out for completeness.
>
> As for the wording; fair enough, I'll wait to see if what you send's an
> improvement or not.
>
Here's my 2c on the doc. I can do it up as a diff against fvwm.1 once we agree
on the language.
* Capitalization of "HotKey" is inconsistent. Existing usage within the man
page uses lower-case k, e.g.
AutomaticHotkeys
NoHotkeys
* Use of the phrase "button presses" doesn't tell the whole story: The option
affects the semantics for invocation of the action associated with a menu
item, by whatever means that invocation occurs: Mouse button or <cr> or
<space>.
* The name "HotKeyActivatesLastSelectedItem" is somewhat inapt to its function.
It doesn't apply to the "last selected item" in any temporal or positional
sense; it applies only in the specific case in which a particular hotkey has
been associated with exactly one menu item. In the contrasting case in which
a single hotkey has been associated with multiple menu items, this option has
no effect at all on menu behavior, and yet it is only in this latter situation
that the notion of "last" (as pertaining to temporal or positional ordering)
has any meaning. Thus, naming it as "last" creates a misleading implication
-- that it pertains to time or position ordering -- which is not reflected
in any way in the option's actual behavior.
My suggestion would be to rename the option to something along the lines of
"HotkeyActivatesImmediate", or perhaps "UniqueHotkeyActivatesImmediate", and
then document it something like this:
------------------------------------------------------------------------------
This option applies only to the case in which a hotkey is associated with
exactly one item in a menu: If the option is enabled, then typing such a
uniquely-associated hotkey immediately invokes the action associated with
the menu item, and the menu is then closed. If the option is disabled, then
typing the hotkey does not immediately invoke the action; it only visually
selects (highlights) the associated item, but the menu remains open. The user
must then explicitly confirm the selection (via key <cr>, key <space>, or
clicking the appropriate mouse button) upon which the associated action is
invoked and the menu closed.
Note that this option has no effect in the case in which a given hotkey
is associated with multiple menu items: In this situation, the confirming
user action (via <cr>, <space>, or mouse button) is always required.
The default setting for this option is HotkeyActivatesImmediate.
------------------------------------------------------------------------------
- gdg
