Johan Lindquist
Mon, 25 Jan 2010 04:10:55 -0800
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Niclas,
I agree with you - I don't want tab characters in the source either, but checkstyle would not instantiate the task & I may have been a little hasty in committing it disabled while looking for a work-around (too many things are broken in the gaderian build due to version changes and wanted to stabilize the build before digging deeper into it). Will revert once i find a fix - that should not have gone in like that. Cheers, Johan Niclas Hedhman wrote: > On Fri, Jan 22, 2010 at 6:45 AM, Johan Lindquist <jo...@kawoo.co.uk> wrote: > >> Seems that the checkstyle version used by the maven checkstyle plugin >> has changed and the current 'style' configuration in use is no longer >> valid - anyone else seen issues with it? For example, it is complaining >> that it is 'Unable to instantiate PackageHtml'. > > You also made some changes... > > 1. You made "Trailing Spaces" allowed. > > 2. You made "TabCharacter" allowed > > I don't have too much opinion about the first (although I think it is > good taste to ensure no trailing spaces), but the second is just > nasty, and I would like to have that revoked. > > What is the reason you think that Tab characteer is anywhere near useful? > My objection is that ALL source files where tab character is allowed > will get its formatting buggered up, since the use of the character is > not well-defined. Some editors have a "every 8th position" and some > editors are "every indent" which are drastically different, and > incompatible between each other. See example; Open a JDK class in IDEA > with indent == 4 (which is the indent JDK uses). > > > Cheers - -- you too? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAktdiisACgkQpHYnED7evirwAgCdFIrwOgQCOf0o5Dr6gNfS36Br dFAAn16neK+5u1A5RBP+f9ctEuw7upMd =neHD -----END PGP SIGNATURE----- _______________________________________________ general mailing list general@lists.ops4j.org http://lists.ops4j.org/mailman/listinfo/general