[issues] Issue Comment Edited: (PAXRUNNER-47) Find a way to avoid quotes (") arround options.

[Ciprian Popa (JIRA)]

    [ 
http://issues.ops4j.org/browse/PAXRUNNER-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13303#action_13303
 ] 

Ciprian Popa edited comment on PAXRUNNER-47 at 2/1/10 2:14 PM:
---------------------------------------------------------------

I already suggested the fix here: 
http://adreghiciu.wordpress.com/2009/12/18/hot-deploy-war-files-in-osgi/#comment-52
 ... so here are the details:

This problem was also mentioned in PAX Runner FAQ ("009. I'm using Pax Runner 
on DOS/Windows, I have the right command but I'm getting strange errors") 
It can be easily fixed by using Windows command line arguments expansion with 
"%*" ("percent and start") in the launcher scripts, so just replace "%1 %2 %3 
%4 %5 %6 %7 %8 %9″ with "%*" ("percent and start").
An additional benefit of this fix will be that now you'll support more then 9 
arguments (without additional "shifts")

So here it is how the pax-run.bat files should look (use it as a template for 
the other Pax tools too):
———-

@echo off
SETLOCAL
set _SCRIPTS_=%~dp0
java %JAVA_OPTS% -cp ".;%_SCRIPTS_%;%_SCRIPTS_%\pax-runner-1.3.0.jar" 
org.ops4j.pax.runner.Run %*

or with an additional variable declaration (not in-place expansion as above)

@echo off
SETLOCAL
set _SCRIPTS_=%~dp0
set PAX_ARGS=%*
java %JAVA_OPTS% -cp ".;%_SCRIPTS_%;%_SCRIPTS_%\pax-runner-1.3.0.jar" 
org.ops4j.pax.runner.Run %PAX_ARGS%

———-

In the meantime, until you'll release a new version of scripts with 
this/similar fix, everybody interested can just simply change their current PAX 
Windows launchers accordingly:



      was (Author: cyparu):
    I already suggested the fix here: 
http://adreghiciu.wordpress.com/2009/12/18/hot-deploy-war-files-in-osgi/#comment-52
 ... so here are the details:

This problem was also mentioned in PAX Runner FAQ ("009. I'm using Pax Runner 
on DOS/Windows, I have the right command but I'm getting strange errors") 
It can be easily fixed by using Windows command line arguments expansion with 
"%*" in the launcher scripts, so just replace "%1 %2 %3 %4 %5 %6 %7 %8 %9″ with 
"%*".
An additional benefit of this fix will be that now you'll support more then 9 
arguments (without additional "shifts")

So here it is how the pax-run.bat files should look (use it as a template for 
the other Pax tools too):
———-

@echo off
SETLOCAL
set _SCRIPTS_=%~dp0
java %JAVA_OPTS% -cp ".;%_SCRIPTS_%;%_SCRIPTS_%\pax-runner-1.3.0.jar" 
org.ops4j.pax.runner.Run %*

or with an additional variable declaration (not in-place expansion as above)

@echo off
SETLOCAL
set _SCRIPTS_=%~dp0
set PAX_ARGS=%*
java %JAVA_OPTS% -cp ".;%_SCRIPTS_%;%_SCRIPTS_%\pax-runner-1.3.0.jar" 
org.ops4j.pax.runner.Run %PAX_ARGS%

———-

In the meantime, until you'll release a new version of scripts with 
this/similar fix, everybody interested can just simply change their current PAX 
Windows launchers accordingly:


  
> Find a way to avoid quotes (") arround options.
> -----------------------------------------------
>
>                 Key: PAXRUNNER-47
>                 URL: http://issues.ops4j.org/browse/PAXRUNNER-47
>             Project: Pax Runner
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alin Dreghiciu
>            Assignee: Alin Dreghiciu
>            Priority: Minor
>
> Find out if there is possible to avoid quotes (") arround options.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.ops4j.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
general mailing list
general@lists.ops4j.org
http://lists.ops4j.org/mailman/listinfo/general