On 12/09/19 12:04AM, Pratyush Yadav wrote:
> On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote:
> > Hi Pratyush,
> >
> > I'm hoping this will be merged, even without changing the radio
> > selectors to a checkbox(?). The patch from Bert resolves the issue I
> > raised about wanting the hotkey.
> > What do you think?
>
> What do you mean by "this"? I am guessing you mean [0].
>
> I'm afraid that patch conflicts with Bert's change [1] to using a
> checkbox. Since both patches are in flight, it makes more sense to base
> your work off his. If I merge your patch now, I'll have to revert it as
> soon as it is time to merge Bert's, and then rework your patch.
>
> Also, after Bert's patch, the toggling becomes much simpler. All you'd
> have to do is something like:
>
> bind . <$M1B-Key-e> {
> # Toggle commit type.
> set commit_type_is_amend [expr {!$commit_type_is_amend}]
> do_select_commit_type
> }
I forgot to mention one more thing. You'd also want to mark the menu
entry of the amend toggle with Ctrl+e keybinding, like we do for all
other bindings (F5 for rescan, Ctrl+T for staging, etc.).
--
Regards,
Pratyush Yadav
