Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e5df70ab194543522397fa3da8c8f80564a0f7d3
Commit:     e5df70ab194543522397fa3da8c8f80564a0f7d3
Parent:     745329c4a2a25efbf5ba6cd7842e07840e4e9775
Author:     Andy Whitcroft <[EMAIL PROTECTED]>
AuthorDate: Sat Feb 23 15:23:32 2008 -0800
Committer:  Linus Torvalds <[EMAIL PROTECTED]>
CommitDate: Sat Feb 23 17:12:13 2008 -0800

    hugetlb: ensure we do not reference a surplus page after handing it to buddy
    
    When we free a page via free_huge_page and we detect that we are in surplus
    the page will be returned to the buddy.  After this we no longer own the 
page.
    
    However at the end free_huge_page we clear out our mapping pointer from
    page private.  Even where the page is not a surplus we free the page to
    the hugepage pool, drop the pool locks and then clear page private.  In
    either case the page may have been reallocated.  BAD.
    
    Make sure we clear out page private before we free the page.
    
    Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
    Acked-by: Adam Litke <[EMAIL PROTECTED]>
    Cc: <[EMAIL PROTECTED]>
    Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
    Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
---
 mm/hugetlb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index cb1b3a7..89e6286 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -120,6 +120,7 @@ static void free_huge_page(struct page *page)
        struct address_space *mapping;
 
        mapping = (struct address_space *) page_private(page);
+       set_page_private(page, 0);
        BUG_ON(page_count(page));
        INIT_LIST_HEAD(&page->lru);
 
@@ -134,7 +135,6 @@ static void free_huge_page(struct page *page)
        spin_unlock(&hugetlb_lock);
        if (mapping)
                hugetlb_put_quota(mapping, 1);
-       set_page_private(page, 0);
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to