Re: r18581 - gnucash/trunk - Bug #607522: Add ADDRESS to check printing

[Derek Atkins]

Hi,

Jan Arne Petersen <j...@gnome.org> writes:

> Attached a patch to fix that bug (and simplifies checks/Makefile.am)
>
> Best regards,
> Jan Arne Petersen
>
>
> diff --git a/checks/Makefile.am b/checks/Makefile.am
> index cd5492a..e786bc7 100644
> --- a/checks/Makefile.am
> +++ b/checks/Makefile.am
> @@ -2,24 +2,15 @@
>  checksdir = ${GNC_CHECKS_DIR}
>  
>  if HAVE_GTK_2_10
> -checks_DATA = \
> +dist_checks_DATA = \
>       deluxe.chk \
>       liberty.chk \
>       quicken.chk \
>       voucher.chk \
>       quicken_wallet.chk
>  else
> -checks_DATA = \
> +dist_checks_DATA = \
>       gnomeprint/deluxe.chk \
>       gnomeprint/quicken.chk \
>       gnomeprint/quicken_wallet.chk
>  endif
> -
> -EXTRA_DIST = \
> -     deluxe.chk \
> -     liberty.chk \
> -     quicken.chk \
> -     quicken_wallet.chk \
> -     gnomeprint/deluxe.chk \
> -     gnomeprint/quicken.chk \
> -     gnomeprint/quicken_wallet.chk

This patch is bad.  It breaks EXTRA_DIST so what you distribute is based
on what Gtk version you have.  Bad Bad Bad!  you must always distribute
all the check files, not just the check files you personally need!

This extra stuff in the Makefile is required until we can remove the
older dependency.

So please DO NOT apply this patch!

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warl...@mit.edu                        PGP key available
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel