[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942595#comment-15942595 ]
ASF GitHub Bot commented on LANG-1317: -------------------------------------- Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 Another bad thing is that `getMethodsWithAnnotation(cls, annotationCls, false, false)` will be a duplicate for `getMethodsWithAnnotation(cls, annotationCls)`. Another solution is to keep my current changes not modified but add following javadoc: ``` * * <p>To lookup annotations on the given class level only choose {@code get*()} methods * and to lookup in the entire inheritance hierarchy of the given class and ignore * accessibility, choose {@code find*()} methods</p> * * @since 2.5 */ public class MethodUtils { ``` > Add findAnnotation and findMethodsWithAnnotation to MethodUtils > --------------------------------------------------------------- > > Key: LANG-1317 > URL: https://issues.apache.org/jira/browse/LANG-1317 > Project: Commons Lang > Issue Type: Improvement > Components: lang.reflect.* > Reporter: Yasser Zamani > Labels: patch > > In order to fix WW-4744 , mainly, I am going to add two functionalities to > MethodUtils: findAnnotation and findMethodsWithAnnotation. > findAnnotation will be an extension for Method.getAnnotation that also > searches interfaces and super classes while caching results with no memory > leak. > findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation > that also supports non public methods, super class and interface methods, > again, while caching results as above. > Generally, do you agree with these in a pull request? If so, I will be > working on it :) -- This message was sent by Atlassian JIRA (v6.3.15#6346)