[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946564#comment-15946564
 ] 

ASF GitHub Bot commented on LANG-1317:
--------------------------------------

Github user yasserzamani commented on the issue:

    https://github.com/apache/commons-lang/pull/261
  
    Thank you @Abrasha ,
    
    I signed up with [coveralls.io](http://coveralls.io) and see that all of 
this PR's changes are covered with unit tests: 
[MethodUtils](https://coveralls.io/jobs/24310263/source_files/797094203#L845) , 
[ClassUtils](https://coveralls.io/jobs/24310263/source_files/797094115#L477).
    
    Also these files show enhancement in coverage at [COVERAGE 
CHANGED](https://coveralls.io/jobs/24310263) :thinking: 


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---------------------------------------------------------------
>
>                 Key: LANG-1317
>                 URL: https://issues.apache.org/jira/browse/LANG-1317
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: Yasser Zamani
>              Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to