[ 
https://issues.apache.org/struts/browse/SHALE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41329
 ] 

Rahul Akolkar commented on SHALE-454:
-------------------------------------

I believe if the positions stack is empty, then the dialog definition this 
context is currently associated with should be the dialog definition this 
context was instantiated with (even though it is not "active"). Therefore, I'd 
like to apply the following patch to the getName() method, but wanted to post 
it here for comments first.

Index: BasicDialogContext.java
===================================================================
--- BasicDialogContext.java     (revision 544613)
+++ BasicDialogContext.java     (working copy)
@@ -258,7 +258,7 @@
         if (position != null) {
             return position.getDialog().getName();
         } else {
-            return null;
+            return dialog.getName();
         }
 
     }


> extending AbstractDialogContextListener getDialogContext().getName() returns 
> null in onStart() method
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHALE-454
>                 URL: https://issues.apache.org/struts/browse/SHALE-454
>             Project: Shale
>          Issue Type: Bug
>          Components: Dialog
>    Affects Versions: 1.1.0-SNAPSHOT
>            Reporter: mario buonopane
>
> i'm using Shale Basic Dialog 1.1.0 and I have a my DialogContextListener 
> extending AbstractDialogContextListener. In onStart() and onStop() methods, 
> getDialogContext().getName() returns null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to