H. Peter Anvin
Mon, 10 Sep 2007 15:51:44 -0700
Andi Kleen wrote: >> The below are the minimal clean-up - a bit more could be done. >> >> Comments? > > Looks good in principle. My only suggestion would be to name it something > differently than vdir. I know that's what GNU make calls it, but it's still > pretty cryptic. How about just fallback-dir ? > > Also what would be nice (I don't know if it's doable in make) would > be a separate variable (e.g. other-obj-... := ) that contains the fallback > names and that is double checked against the fallback directory. That > would document it clearly what's going on. Failing that stuffing > them into a comment would be good at least. >
<nitpick>
Actually make calls it VPATH, not vdir.
-hpa
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel