Re: The problem with UTF-8 capable ftp sites

[Hasso Tepper]

Alexander V. Lukyanov wrote:
> On Wed, Sep 16, 2009 at 10:55:20AM +0300, Hasso Tepper wrote:
> > The point is that "//TRANSLIT" is unnecessary and really invalid
> > argument for Citrus iconv_open. Also, shouldn't it behave more sanely
> > if iconv_open() is failing for whatever reason?
>
> Please try this patch. It fixes both problems.

Yes, it does. Thanks! While I'm on it, some more little problems in lftp
discovered on platforms using pkgsrc:

- src/ChmodJob.cc needs to include unistd.h for strmode(3).
- src/Torrent.cc needs to include sys/stat.h for mkdir(2).
- time_t is 64 bits in recent NetBSD versions even on i386 platform, 
  therefore these assertaions fail on it:

  in lib/mktime.c:
  verify (long_int_year_and_yday_are_wide_enough,
        INT_MAX <= LONG_MAX / 2 || TIME_T_MAX <= UINT_MAX);

  in lib/getdate.y:
  verify (LONG_MIN <= TYPE_MINIMUM (time_t) && TYPE_MAXIMUM (time_t) <= 
    LONG_MAX);


regards,

-- 
Hasso Tepper