On 2017/04/07 17:30:25, dak wrote:
On 2017/04/05 15:55:38, david.nalesnik wrote: > On 2017/04/05 15:47:19, pkx166h wrote: > > Do you want this tested? > > > > I cannot see any tracker issue for this. > > > > Or is this just some work-in-progress design before you have a
patch for
> testing > > proper? > > > > James > > It's associated with Issue 4276. > > It would be great if you could test this. > > I do think that some discussion is in order over the relative merits
of this
> context-property approach vs. the tweaking approach linked to in the description > of 4276. > > Thanks!
My personal take on this would be to allow overriding, say, \override Script.accent.padding = #2.0 . And maybe that's where all of the
script
definitions should be in the first place.
Yes, I've considered just this syntax and believe it would be best. The context-property method breaks down because of the way create_script_from_event in lily/script-engraver.cc negotiates between properties listed in scriptDefinitions (or, by extension, in the property scriptExceptions added by the patch) on the one hand, and properties from the grob-definition of Script/possibly introduced by user overrides on the other. The user expectation would be that any property they put in scriptExceptions should have an effect, but that's not the case because of the fragile way create_script_from_event creates its property lists. Values for 'staff-padding are thrown out, because the value in the grob-description of Script (0.15) is an acceptable value (ly:dimension?). Values for 'rotation are also thrown out -- here because the default value is unset, meaning '(), which is an acceptable value for 'rotation because the property takes a list! I see no way to make a context property holding exceptions work with the system in place. (Which is why I set the patch to needs work.) I'll work on putting an override system in place. https://codereview.appspot.com/324740043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
