Re: r2llib-0.10 code review

[mulix]

hi emil,

thank you for your code review! i have read it, and i agree with some of
the issues and disagree with the others.

since i'm going on vacation in less than two hours, the new version will
have to wait until i get back, on thursday.

if you (or anyone else) want to make changes to r2llib in the mean time-
consider this an invitation to do so. happy hacking!

On Sun, 29 Jul 2001, Kohn Emil Dan wrote:

> Hi mulix,
>
> > absolute path names are in, but i would appreciate someone else
> > reviewing the code. it's in r2llib.c, r2l_init().
>
> Ok, I have reviewed all your r2llib code. The review is attached to this
> message. You can read it as it is or you can use it more effectively (in
> my opinion) like this:
>
> 1) save the attachment to a file, say r2llib-0.10-review.txt in the r2llib
> project directory
> 2) Launch emacs from that directory
> 3) Issue M-x compile
> 4) As a compilation command type: cat r2llib-0.10-review.txt
> 5) Check each `error' (i.e. comment) with C-x` (Ctrl-x backtick)
>
> I think that this is a nice hack. What do you think?

very neat hack indeed - emacs lecture material :)
-- 
mulix
http://www.advogato.com/person/mulix

linux/reboot.h: #define LINUX_REBOOT_MAGIC1 0xfee1dead